diffplug / diffplug/gitcasso

give `corpus-view.ts` an interlock to warn about gitcasso running

未关闭
#75 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
enhancement
主要语言
HTML
星标
58
派生
0
PR 合并指标
30 天内没有已合并 PR

描述

- when testing gitcasso using `pnpm corpus`
- if you have the gitcasso extension installed in your browser (dev or prod, doesn't matter)
- then you will get extremely misleading results
- right now we warn in the docs
- https://github.com/diffplug/gitcasso/blob/45ea112f09ad67947f0c2d10394251356e5599b4/CONTRIBUTING.md#L89-L91
- it would be much better if we could somehow detect that the browser extension was running, and give a big fat warning if that is the case
- maybe if `content.ts` runs on `localhost` we add some header into the DOM
- and then `corpus-view.ts` has some js that looks for that and makes a big warning div
- then we can remove the warning in `CONTRIBUTING.md`
- I have already lost hours to this mistake, new contributors are guaranteed to lose more

贡献指南

打开贡献指南

调研方向

Start by reading corpus-view.ts and content.ts, then review the warning section in CONTRIBUTING.md. Run pnpm corpus with the gitcasso browser extension enabled to reproduce the misleading results. Done means the corpus view shows a prominent warning when the extension is active on localhost, and the redundant documentation warning can be removed.

由索引模型根据 Issue 内容生成。

评估

技术栈
typescript
领域
developer-experience, frontend
Issue 类型
功能
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
42/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。