diffplug / diffplug/gitcasso

give `corpus-view.ts` an interlock to warn about gitcasso running

Ouverte
#75 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
enhancement
Langage dominant
HTML
Étoiles
58
Forks
0
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

- when testing gitcasso using `pnpm corpus`
- if you have the gitcasso extension installed in your browser (dev or prod, doesn't matter)
- then you will get extremely misleading results
- right now we warn in the docs
- https://github.com/diffplug/gitcasso/blob/45ea112f09ad67947f0c2d10394251356e5599b4/CONTRIBUTING.md#L89-L91
- it would be much better if we could somehow detect that the browser extension was running, and give a big fat warning if that is the case
- maybe if `content.ts` runs on `localhost` we add some header into the DOM
- and then `corpus-view.ts` has some js that looks for that and makes a big warning div
- then we can remove the warning in `CONTRIBUTING.md`
- I have already lost hours to this mistake, new contributors are guaranteed to lose more

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.