diffplug / diffplug/gitcasso

give `corpus-view.ts` an interlock to warn about gitcasso running

Aperta
#75 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
enhancement
Lingua principale
HTML
Stelle
58
Fork
0
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

- when testing gitcasso using `pnpm corpus`
- if you have the gitcasso extension installed in your browser (dev or prod, doesn't matter)
- then you will get extremely misleading results
- right now we warn in the docs
- https://github.com/diffplug/gitcasso/blob/45ea112f09ad67947f0c2d10394251356e5599b4/CONTRIBUTING.md#L89-L91
- it would be much better if we could somehow detect that the browser extension was running, and give a big fat warning if that is the case
- maybe if `content.ts` runs on `localhost` we add some header into the DOM
- and then `corpus-view.ts` has some js that looks for that and makes a big warning div
- then we can remove the warning in `CONTRIBUTING.md`
- I have already lost hours to this mistake, new contributors are guaranteed to lose more

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start by reading corpus-view.ts and content.ts, then review the warning section in CONTRIBUTING.md. Run pnpm corpus with the gitcasso browser extension enabled to reproduce the misleading results. Done means the corpus view shows a prominent warning when the extension is active on localhost, and the redundant documentation warning can be removed.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
typescript
Ambito
developer-experience, frontend
Tipo di issue
Funzionalità
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
42/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.