developit / developit/workerize

Consider removing expose(), call() and kill() ?

未关闭
#26 4 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
enhancement help wanted
主要语言
JavaScript
星标
4.4k
派生
87
PR 合并指标
30 天内没有已合并 PR

描述

``` javascript
worker.expose = methodName => {
worker[i] = function() {
return worker.call(methodName, [].slice.call(arguments));
};
};
```
Instead `methodName` parameter should be used:
``` javascript
worker.expose = methodName => {
worker[methodName] = function() {
return worker.call(methodName, [].slice.call(arguments));
};
};
```
Beside that I don't see why the `call` and `expose` methods are accessible from outside. (Don't assign to worker at all)
The purpose of the `kill` method is also not clear for me.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。