developit / developit/workerize
Consider removing expose(), call() and kill() ?
- Lenguaje dominante
- JavaScript
- Estrellas
- 4.4k
- Forks
- 87
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
``` javascript
worker.expose = methodName => {
worker[i] = function() {
return worker.call(methodName, [].slice.call(arguments));
};
};
```
Instead `methodName` parameter should be used:
``` javascript
worker.expose = methodName => {
worker[methodName] = function() {
return worker.call(methodName, [].slice.call(arguments));
};
};
```
Beside that I don't see why the `call` and `expose` methods are accessible from outside. (Don't assign to worker at all)
The purpose of the `kill` method is also not clear for me.
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Línea de trabajo
Start by tracing the public worker.expose, worker.call, and worker.kill entry points referenced in the issue. Determine the intended public API and worker lifecycle behavior before changing anything; done requires a maintainer decision plus corresponding implementation and tests, which the issue does not identify.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- javascript
- Área
- web-dev
- Tipo de issue
- Refactorización
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Necesita aclaración
- Aptitud para principiantes
- 25/100