developit / developit/workerize
Consider removing expose(), call() and kill() ?
Ouverte
enhancement
help wanted
- Langage dominant
- JavaScript
- Étoiles
- 4.4k
- Forks
- 87
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
``` javascript
worker.expose = methodName => {
worker[i] = function() {
return worker.call(methodName, [].slice.call(arguments));
};
};
```
Instead `methodName` parameter should be used:
``` javascript
worker.expose = methodName => {
worker[methodName] = function() {
return worker.call(methodName, [].slice.call(arguments));
};
};
```
Beside that I don't see why the `call` and `expose` methods are accessible from outside. (Don't assign to worker at all)
The purpose of the `kill` method is also not clear for me.
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Évaluation
Cette issue n'a pas encore été évaluée.