devcontainers / devcontainers/cli

Docker compose profile specification

Aperta
#669 5 commenti 6 reazioni 1 assegnatario Rivendicata da @chrmarti Vedi su GitHub
bug
Lingua principale
TypeScript
Stelle
3k
Fork
457
Merge medio
13h 17m
PR unite (30g)
6

Descrizione

Currently we have an application that can use either mariadb or postgresql. To achieve this, we leveraged docker-compose's profiles & environment variable COMPOSE_PROFILE to pass on the desired profile.

But [devcontainer script ](https://github.com/devcontainers/cli/blob/5a5a9b209d673a4b9e5389f6d64ac124cce3ec62/src/spec-node/dockerCompose.ts#L570) is passing --profile * to the docker-compose command by default without taking into account the desired profile specified in COMPOSE_PROFILE.

Can the script be modified to look for COMPOSE_PROFILE variable first before setting --profile *?

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.