devcontainers / devcontainers/cli
Docker compose profile specification
Ouverte
bug
- Langage dominant
- TypeScript
- Étoiles
- 3k
- Forks
- 457
- Merge moyen
- 13 h 17 min
- PR mergées (30 j)
- 6
Description
Currently we have an application that can use either mariadb or postgresql. To achieve this, we leveraged docker-compose's profiles & environment variable COMPOSE_PROFILE to pass on the desired profile.
But [devcontainer script ](https://github.com/devcontainers/cli/blob/5a5a9b209d673a4b9e5389f6d64ac124cce3ec62/src/spec-node/dockerCompose.ts#L570) is passing --profile * to the docker-compose command by default without taking into account the desired profile specified in COMPOSE_PROFILE.
Can the script be modified to look for COMPOSE_PROFILE variable first before setting --profile *?
Guide de contribution
Ouvrir le guide de contribution
Évaluation
Cette issue n'a pas encore été évaluée.