devcontainers / devcontainers/cli

Docker compose profile specification

Abierto
#669 5 comentarios 6 reacciones 1 asignado Reclamado por @chrmarti Ver en GitHub
bug
Lenguaje dominante
TypeScript
Estrellas
3k
Forks
457
Merge medio
13 h 17 min
PR fusionados (30 d)
6

Descripción

Currently we have an application that can use either mariadb or postgresql. To achieve this, we leveraged docker-compose's profiles & environment variable COMPOSE_PROFILE to pass on the desired profile.

But [devcontainer script ](https://github.com/devcontainers/cli/blob/5a5a9b209d673a4b9e5389f6d64ac124cce3ec62/src/spec-node/dockerCompose.ts#L570) is passing --profile * to the docker-compose command by default without taking into account the desired profile specified in COMPOSE_PROFILE.

Can the script be modified to look for COMPOSE_PROFILE variable first before setting --profile *?

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.