devcontainers / devcontainers/cli

Docker compose profile specification

Open
#669 5 comments 6 reactions 1 assignee Claimed by @chrmarti View on GitHub
bug
Dominant language
TypeScript
Stars
3k
Forks
457
Avg merge
13h 17m
Merged PRs (30d)
6

Description

Currently we have an application that can use either mariadb or postgresql. To achieve this, we leveraged docker-compose's profiles & environment variable COMPOSE_PROFILE to pass on the desired profile.

But [devcontainer script ](https://github.com/devcontainers/cli/blob/5a5a9b209d673a4b9e5389f6d64ac124cce3ec62/src/spec-node/dockerCompose.ts#L570) is passing --profile * to the docker-compose command by default without taking into account the desired profile specified in COMPOSE_PROFILE.

Can the script be modified to look for COMPOSE_PROFILE variable first before setting --profile *?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.