cuappdev / cuappdev/score-android

Refactor ScoreBox to accept ScoreBoxViewState

未关闭
#84 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Kotlin
星标
3
派生
0
PR 合并指标
30 天内没有已合并 PR

描述

Ideally `mapToPeriodScores` should be done in the VM, and the `ScoreBox` component as a whole should accept `ScoreBoxViewState` instead of `GameData`. But if you don't want to refactor all of this right now we don't have to. For now, you could just make `toPeriodScores` a function on the `GameData` `data class`.

_Originally posted by @zachseidner1 in https://github.com/cuappdev/score-android/pull/83#discussion_r2370251309_

贡献指南

这个仓库没有索引到贡献指南

调研方向

Start by tracing ScoreBox, ScoreBoxViewState, GameData, mapToPeriodScores, and toPeriodScores through the view model and component. Decide whether the full view-state refactor or the smaller GameData change is intended, then verify that ScoreBox receives the chosen state and period scores still render correctly.

由索引模型根据 Issue 内容生成。

评估

技术栈
android, kotlin
领域
mobile
Issue 类型
重构
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
需要澄清
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。