cuappdev / cuappdev/score-android

Refactor ScoreBox to accept ScoreBoxViewState

Open
#84 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
3
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Ideally `mapToPeriodScores` should be done in the VM, and the `ScoreBox` component as a whole should accept `ScoreBoxViewState` instead of `GameData`. But if you don't want to refactor all of this right now we don't have to. For now, you could just make `toPeriodScores` a function on the `GameData` `data class`.

_Originally posted by @zachseidner1 in https://github.com/cuappdev/score-android/pull/83#discussion_r2370251309_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.