commercetools / commercetools/nodejs

Migrate missing features and fixes from old SDK

Aperta
#591 1 commento 3 reazioni 0 assegnatari Vedi su GitHub
Type: Discussion
Lingua principale
JavaScript
Stelle
77
Fork
70
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

**Topic for discussion**

It is pity that we hit same [issues](https://github.com/commercetools/nodejs/pull/590) with new SDK which has been addressed in [old SDK](https://github.com/sphereio/sphere-node-sdk/blob/master/src/coffee/sync/product-sync.coffee#L44-L56) already as for existing customers migration might be a costly enterprise as they might hit issues that were not present with old SDK. The reason is obviously that rewrite of new SDK was based on old SDK and as it took around 1 year of development all the fixes/features applied to old SDK during that time were not migrated to the new SDK release.

**Suggestion**

Review all issues/PRs/commits from old SDK implemented after rewrite fork and create a list of TODOs for migration like examples below.

**Missing fixes/features**
- [ ] - Sync actions should first [remove variants](https://github.com/sphereio/sphere-node-sdk/blob/master/src/coffee/sync/product-sync.coffee#L45)
- [ ] - fetch all [convenience function](https://github.com/sphereio/sphere-node-sdk/blob/master/src/coffee/services/base.coffee#L227) for multi-paged results
- [ ] - GraphQL convenience method which allows to do GraphQL requests with single line instead of boiler plate utils in every project
- [ ] - Provide GraphQL process function for paginated results and fetch all if one needs to load all paginated results into memory.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Esamina i vecchi riferimenti all’SDK in src/coffee/sync/product-sync.coffee e src/coffee/services/base.coffee, insieme al PR 590 collegato. Confronta issues, PR e commit successivi al fork con il nuovo SDK, quindi documenta le correzioni e le funzionalità mancanti come lista TODO per la migrazione; il lavoro sarà completato quando sarà disponibile una lista verificata e attuabile che copra gli esempi nell’issue.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
graphql, javascript, node.js
Ambito
api, backend
Tipo di issue
Funzionalità
Difficoltà
5/5
Tempo stimato
Più di una settimana
Stato di attività
Ferma
Chiarezza
Da chiarire
Idoneità per principianti
20/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.