commercetools / commercetools/nodejs

Migrate missing features and fixes from old SDK

Offen
#591 1 Kommentar 3 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Type: Discussion
Vorherrschende Sprache
JavaScript
Sterne
77
Forks
70
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

**Topic for discussion**

It is pity that we hit same [issues](https://github.com/commercetools/nodejs/pull/590) with new SDK which has been addressed in [old SDK](https://github.com/sphereio/sphere-node-sdk/blob/master/src/coffee/sync/product-sync.coffee#L44-L56) already as for existing customers migration might be a costly enterprise as they might hit issues that were not present with old SDK. The reason is obviously that rewrite of new SDK was based on old SDK and as it took around 1 year of development all the fixes/features applied to old SDK during that time were not migrated to the new SDK release.

**Suggestion**

Review all issues/PRs/commits from old SDK implemented after rewrite fork and create a list of TODOs for migration like examples below.

**Missing fixes/features**
- [ ] - Sync actions should first [remove variants](https://github.com/sphereio/sphere-node-sdk/blob/master/src/coffee/sync/product-sync.coffee#L45)
- [ ] - fetch all [convenience function](https://github.com/sphereio/sphere-node-sdk/blob/master/src/coffee/services/base.coffee#L227) for multi-paged results
- [ ] - GraphQL convenience method which allows to do GraphQL requests with single line instead of boiler plate utils in every project
- [ ] - Provide GraphQL process function for paginated results and fetch all if one needs to load all paginated results into memory.

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Review the old SDK references in src/coffee/sync/product-sync.coffee and src/coffee/services/base.coffee, along with the linked PR 590. Compare post-fork issues, PRs, and commits with the new SDK, then document the missing fixes and features as a migration TODO list; completion is a reviewed, actionable list covering the examples in the issue.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
graphql, javascript, node.js
Bereich
api, backend
Issue-Typ
Feature
Schwierigkeit
5/5
Geschätzter Aufwand
Über eine Woche
Aktivitätsstatus
Veraltet
Klarheit
Muss geklärt werden
Anfängerfreundlichkeit
20/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.