commercetools / commercetools/nodejs

Migrate missing features and fixes from old SDK

Abierto
#591 1 comentario 3 reacciones 0 asignados Ver en GitHub
Type: Discussion
Lenguaje dominante
JavaScript
Estrellas
77
Forks
70
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

**Topic for discussion**

It is pity that we hit same [issues](https://github.com/commercetools/nodejs/pull/590) with new SDK which has been addressed in [old SDK](https://github.com/sphereio/sphere-node-sdk/blob/master/src/coffee/sync/product-sync.coffee#L44-L56) already as for existing customers migration might be a costly enterprise as they might hit issues that were not present with old SDK. The reason is obviously that rewrite of new SDK was based on old SDK and as it took around 1 year of development all the fixes/features applied to old SDK during that time were not migrated to the new SDK release.

**Suggestion**

Review all issues/PRs/commits from old SDK implemented after rewrite fork and create a list of TODOs for migration like examples below.

**Missing fixes/features**
- [ ] - Sync actions should first [remove variants](https://github.com/sphereio/sphere-node-sdk/blob/master/src/coffee/sync/product-sync.coffee#L45)
- [ ] - fetch all [convenience function](https://github.com/sphereio/sphere-node-sdk/blob/master/src/coffee/services/base.coffee#L227) for multi-paged results
- [ ] - GraphQL convenience method which allows to do GraphQL requests with single line instead of boiler plate utils in every project
- [ ] - Provide GraphQL process function for paginated results and fetch all if one needs to load all paginated results into memory.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Revisa las referencias antiguas del SDK en src/coffee/sync/product-sync.coffee y src/coffee/services/base.coffee, junto con el PR 590 enlazado. Compara los issues, PRs y commits posteriores al fork con el nuevo SDK y documenta las correcciones y funcionalidades que faltan como una lista TODO de migración; se considerará completado cuando exista una lista revisada y accionable que cubra los ejemplos del issue.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
graphql, javascript, node.js
Área
api, backend
Tipo de issue
Nueva funcionalidad
Dificultad
5/5
Tiempo estimado
Más de una semana
Estado de actividad
Estancado
Claridad
Necesita aclaración
Aptitud para principiantes
20/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.