codingjoe / codingjoe/threadmill
Uncovered pre-existing branches in the executor and worker command
- 主要言語
- Python
- スター
- 12
- フォーク
- 1
- 平均マージ
- 1日 1時間
- マージ済み PR(30日)
- 10
説明
Found by `testJoe` while adding coverage for the fair multi-queue rotation (`codingjoe-fair-multi-queue-scheduling`). All pre-existing, all untouched by that diff. Filed as one item because none of them is worth its own tracker entry.
- `executor.py:278-280` — the `Empty`/`TimeoutError` handler in `WorkerThread.run`. Currently shadowed by the `redis.py:297` thread crash (see the sibling issue about `None` poll intervals), so it never runs in the suite.
- `management/commands/threadmill.py:114` — invalid-backend `CommandError`.
- `management/commands/threadmill.py:122-123,125` — invalid-log-format `CommandError`.
- `management/commands/threadmill.py:153-156` — `KeyboardInterrupt` shutdown branch.
- `management/commands/threadmill.py:176-177` — missing-inspector-dependency `CommandError`.
Add direct tests for each, or delete the branches no caller can reach. `uv run pytest` reports them as missing today.
コントリビューションガイド
調査の方向性
Start by reading executor.py:278-280 and management/commands/threadmill.py at lines 114, 122-123, 125, 153-156, and 176-177. Run `uv run pytest` to reproduce the missing coverage, then add direct tests for each branch or confirm which unreachable branches can be removed. Done means the relevant branches are covered or deleted and the test suite passes.
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- django, python
- 領域
- backend, cli, testing
- issue の種類
- リファクタリング
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 活発さ
- 活発
- 明瞭さ
- 明確に書かれている
- 初心者へのやさしさ
- 72/100