codingjoe / codingjoe/threadmill

Uncovered pre-existing branches in the executor and worker command

Aperta
#54 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Python
Stelle
12
Fork
1
Merge medio
1g 1h
PR unite (30g)
10

Descrizione

Found by `testJoe` while adding coverage for the fair multi-queue rotation (`codingjoe-fair-multi-queue-scheduling`). All pre-existing, all untouched by that diff. Filed as one item because none of them is worth its own tracker entry.

- `executor.py:278-280` — the `Empty`/`TimeoutError` handler in `WorkerThread.run`. Currently shadowed by the `redis.py:297` thread crash (see the sibling issue about `None` poll intervals), so it never runs in the suite.
- `management/commands/threadmill.py:114` — invalid-backend `CommandError`.
- `management/commands/threadmill.py:122-123,125` — invalid-log-format `CommandError`.
- `management/commands/threadmill.py:153-156` — `KeyboardInterrupt` shutdown branch.
- `management/commands/threadmill.py:176-177` — missing-inspector-dependency `CommandError`.

Add direct tests for each, or delete the branches no caller can reach. `uv run pytest` reports them as missing today.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start by reading executor.py:278-280 and management/commands/threadmill.py at lines 114, 122-123, 125, 153-156, and 176-177. Run `uv run pytest` to reproduce the missing coverage, then add direct tests for each branch or confirm which unreachable branches can be removed. Done means the relevant branches are covered or deleted and the test suite passes.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
django, python
Ambito
backend, cli, testing
Tipo di issue
Refactoring
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Attiva
Chiarezza
Specificata chiaramente
Idoneità per principianti
72/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.