coder / coder/code-server

[Feat]: Delegate to upstream remote-cli script

オープン
#5,414 コメント 0 件 リアクション 2 件 担当者 0 名 GitHub で見る
enhancement
主要言語
TypeScript
スター
79.3k
フォーク
6.8k
平均マージ
2日 6時間
マージ済み PR(30日)
41

説明

## What is your suggestion?

Right now we use the script in lib/vscode/bin/remote-cli inside the integrated terminal but we should use it from our own script as well because it provides more than our implementation.

## Why do you want this feature?

So things we have not implemented like `--wait` work even outside code-server and so we can remove our incomplete implementation.

## Are there any workarounds to get this functionality today?

Use an absolute path to run it. Or put it in your PATH but then you could not run the server since that script only allows interacting with existing instances of code-server.

## Are you interested in submitting a PR for this?

Yeah, will probably take this on.

## Implementation notes

Probably easiest to keep the existing logic but then instead of talking to the Code socket ourselves spawn the remote-cli script.

**Edit**: need to make sure it supports stdin as well, see https://github.com/coder/code-server/issues/5693

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。