coder / coder/code-server

[Feat]: Delegate to upstream remote-cli script

未关闭
#5,414 0 条评论 2 个 reaction 已指派 0 人 在 GitHub 查看
enhancement
主要语言
TypeScript
星标
79.3k
派生
6.8k
平均合并
2 天 6 小时
30 天内合并 PR
41

描述

## What is your suggestion?

Right now we use the script in lib/vscode/bin/remote-cli inside the integrated terminal but we should use it from our own script as well because it provides more than our implementation.

## Why do you want this feature?

So things we have not implemented like `--wait` work even outside code-server and so we can remove our incomplete implementation.

## Are there any workarounds to get this functionality today?

Use an absolute path to run it. Or put it in your PATH but then you could not run the server since that script only allows interacting with existing instances of code-server.

## Are you interested in submitting a PR for this?

Yeah, will probably take this on.

## Implementation notes

Probably easiest to keep the existing logic but then instead of talking to the Code socket ourselves spawn the remote-cli script.

**Edit**: need to make sure it supports stdin as well, see https://github.com/coder/code-server/issues/5693

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。