code-corps / code-corps/code-corps-ember
Improve testing coverage after PR
未關閉
- 主要語言
- JavaScript
- 星號
- 120
- 分支
- 75
- PR 合併指標
- 30 天內沒有已合併 PR
描述
# Problem
This [PR](https://github.com/code-corps/code-corps-ember/pull/1463#issuecomment-340201852) resulted in a substantial drop in test coverage (~1%) due to refactoring of imports. This seemingly shouldn't have an impact on testing coverage; however, the current thought is the imports from before this PR were picked up as covered by coveralls when in fact the actual logic was not covered. Here is an [example](https://coveralls.io/builds/13934987/source?filename=app%2Fmixins%2Fonboarding-controller.js).
貢獻指南
研究方向
從 app/mixins/onboarding-controller.js 的 Coveralls 範例開始,將其涵蓋率與 PR 1463 中的變更進行比較,尤其關注 import 重構。找出在沒有測試的情況下被報告為已涵蓋的邏輯,然後為該行為新增涵蓋率,並驗證重構後整體報告不再下降。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- javascript
- 領域
- testing
- Issue 類型
- 重構
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 活躍度
- 停滯
- 描述清晰度
- 需要釐清
- 新手友好度
- 25/100