code-corps / code-corps/code-corps-ember

Improve testing coverage after PR

Ouverte
#1,464 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
JavaScript
Étoiles
120
Forks
75
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

# Problem

This [PR](https://github.com/code-corps/code-corps-ember/pull/1463#issuecomment-340201852) resulted in a substantial drop in test coverage (~1%) due to refactoring of imports. This seemingly shouldn't have an impact on testing coverage; however, the current thought is the imports from before this PR were picked up as covered by coveralls when in fact the actual logic was not covered. Here is an [example](https://coveralls.io/builds/13934987/source?filename=app%2Fmixins%2Fonboarding-controller.js).

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.