code-corps / code-corps/code-corps-ember

Improve testing coverage after PR

未关闭
#1,464 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
JavaScript
星标
120
派生
75
PR 合并指标
30 天内没有已合并 PR

描述

# Problem

This [PR](https://github.com/code-corps/code-corps-ember/pull/1463#issuecomment-340201852) resulted in a substantial drop in test coverage (~1%) due to refactoring of imports. This seemingly shouldn't have an impact on testing coverage; however, the current thought is the imports from before this PR were picked up as covered by coveralls when in fact the actual logic was not covered. Here is an [example](https://coveralls.io/builds/13934987/source?filename=app%2Fmixins%2Fonboarding-controller.js).

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。