code-corps / code-corps/code-corps-ember

Improve testing coverage after PR

Open
#1,464 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
120
Forks
75
PR merge metrics
No merged PRs in 30d

Description

# Problem

This [PR](https://github.com/code-corps/code-corps-ember/pull/1463#issuecomment-340201852) resulted in a substantial drop in test coverage (~1%) due to refactoring of imports. This seemingly shouldn't have an impact on testing coverage; however, the current thought is the imports from before this PR were picked up as covered by coveralls when in fact the actual logic was not covered. Here is an [example](https://coveralls.io/builds/13934987/source?filename=app%2Fmixins%2Fonboarding-controller.js).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.