code-corps / code-corps/code-corps-ember

Deprecation: Native dom helpers should not be used as globals in tests anymore

Open
#1,207 2 comments 0 reactions 0 assignees View on GitHub
Skill: ember-cli-page-object Skill: Ember.js Skill: JavaScript
Dominant language
JavaScript
Stars
120
Forks
75
PR merge metrics
No merged PRs in 30d

Description

# Problem

Using native dom helpers as globals is now deprecated in our tests. Instead, we should add a new dependency to our app and import these helpers from it in any tests that need it.

We are leaning away from these anyway, due to relying on ember-cli-page-object, but there are still a couple of places where we do use them.

## Subtasks
- [ ] Install depdencency https://github.com/cibernox/ember-native-dom-helpers
- [ ] Search through our tests for usage of the `find`, `click`, `fillIn`, `visit` and other global functions in this group. Careful not to mistake them for the identically named functions provided by `ember-cli-page-object`. The culprits we need to fixed are likely used as globals, in tests, directly.
- [ ] In any module that uses them, import them using `import { visit, click, find, fillIn } from 'ember-native-dom-helpers';`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.