code-corps / code-corps/code-corps-ember

Only task authors as well as project contributors or higher can edit task skills.

Open
#1,043 4 comments 0 reactions 0 assignees View on GitHub
blocked Difficulty: Easy needs clarification needs design
Dominant language
JavaScript
Stars
120
Forks
75
PR merge metrics
No merged PRs in 30d

Description

# Problem

Right now on project/tasks/task.hbs, the UI to remove and add task skills is accessible by anyone.

We should change this so that only users who are able to edit tasks can interact with this part of the UI.

## Subtasks

- [ ] Wrap the `skill-button` collection as well as the `skill-typeahead` UI with an `{{#if (can 'edit task' task)}}` block
- [ ] Put a `{{related-skills}} component into the `else` part of the block.
- [ ] Fix any broken tests
- [ ] Add an acceptance test to `acceptance/task-editing-test.js` along the lines of "skills cannot be assigned to/from a task if user is not able to".
- [ ] Possibly: Add properties to `tests/pages/project/tasks/task.js` to support the above acceptance test. Something like `rendersTaskSkillsList`, `rendersRelatedSkills`, `rendersSkillsTypeahead`, etc.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.