code-corps / code-corps/code-corps-api

StripePlatformCardController has unhandled response cases

未關閉
#1,032 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Elixir
星號
234
分支
82
PR 合併指標
30 天內沒有已合併 PR

描述

# Problem

Similar to the issue described in #1031, `StripePlatformCardController` has unhandled response cases, which will all render as a 500.

The difference is, in this case, they are not properly mapped in `CodeCorps.StripeService.StripePlatformCardService` either, so we need to map them there as well.

# Steps needed in order to provide a time estimate

We should consider splitting these into separate tasks

- identify all possible responses for `CodeCorps.StripeService.StripePlatformCardService.create`
- discuss if the responses should be mapped differently
- apply new mapping if any
- handle these responses in the controller/fallback controller

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。