code-corps / code-corps/code-corps-api

StripePlatformCardController has unhandled response cases

Aperta
#1,032 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Elixir
Stelle
234
Fork
82
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

# Problem

Similar to the issue described in #1031, `StripePlatformCardController` has unhandled response cases, which will all render as a 500.

The difference is, in this case, they are not properly mapped in `CodeCorps.StripeService.StripePlatformCardService` either, so we need to map them there as well.

# Steps needed in order to provide a time estimate

We should consider splitting these into separate tasks

- identify all possible responses for `CodeCorps.StripeService.StripePlatformCardService.create`
- discuss if the responses should be mapped differently
- apply new mapping if any
- handle these responses in the controller/fallback controller

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.