code-corps / code-corps/code-corps-api

StripePlatformCardController has unhandled response cases

Open
#1,032 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Elixir
Stars
234
Forks
82
PR merge metrics
No merged PRs in 30d

Description

# Problem

Similar to the issue described in #1031, `StripePlatformCardController` has unhandled response cases, which will all render as a 500.

The difference is, in this case, they are not properly mapped in `CodeCorps.StripeService.StripePlatformCardService` either, so we need to map them there as well.

# Steps needed in order to provide a time estimate

We should consider splitting these into separate tasks

- identify all possible responses for `CodeCorps.StripeService.StripePlatformCardService.create`
- discuss if the responses should be mapped differently
- apply new mapping if any
- handle these responses in the controller/fallback controller

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.