cockroachdb / cockroachdb/examples-orms
Some issues with the Hibernate example
- 主要言語
- Go
- スター
- 82
- フォーク
- 37
- PR マージ指標
- 30日以内にマージされた PR はありません
説明
I'm currently translating some of the Java/Hibernate examples to jOOQ and found a few issues that you may or may not want to address:
### `CustomerService::deleteCustomer` fails when orders have `OrderProduct` entries:
This query here:
https://github.com/cockroachdb/examples-orms/blob/8aacfca23a8b91667aad846e7e41e4e14c7658cc/java/hibernate/src/main/java/com/cockroachlabs/services/CustomerService.java#L83
Will fail in case there are entries in `order_products`, which does not have `ON DELETE CASCADE` clauses on its foreign keys by default (I think). I'm not sure if this is desired here.
### `OrderService::deleteOrder` fails because of wrong query:
This query here:
https://github.com/cockroachdb/examples-orms/blob/8aacfca23a8b91667aad846e7e41e4e14c7658cc/java/hibernate/src/main/java/com/cockroachlabs/services/OrderService.java#L83
Will fail because the `Order` entity doesn't have an `order_id` column. I think the intention here was to delete the record in `order_products`
コントリビューションガイド
このリポジトリのコントリビューションガイドは索引されていません
調査の方向性
Read java/hibernate/src/main/java/com/cockroachlabs/services/CustomerService.java around line 83 and OrderService.java around line 83. Check how each deletion behaves when order_products entries exist, then verify that customer and order deletion no longer fails and that the intended order_products record is removed.
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- java
- 領域
- backend, database
- issue の種類
- バグ
- 難易度
- 2/5
- 見積もり時間
- 1〜2日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 35/100