cockroachdb / cockroachdb/examples-orms
Some issues with the Hibernate example
- Langage dominant
- Go
- Étoiles
- 82
- Forks
- 37
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
I'm currently translating some of the Java/Hibernate examples to jOOQ and found a few issues that you may or may not want to address:
### `CustomerService::deleteCustomer` fails when orders have `OrderProduct` entries:
This query here:
https://github.com/cockroachdb/examples-orms/blob/8aacfca23a8b91667aad846e7e41e4e14c7658cc/java/hibernate/src/main/java/com/cockroachlabs/services/CustomerService.java#L83
Will fail in case there are entries in `order_products`, which does not have `ON DELETE CASCADE` clauses on its foreign keys by default (I think). I'm not sure if this is desired here.
### `OrderService::deleteOrder` fails because of wrong query:
This query here:
https://github.com/cockroachdb/examples-orms/blob/8aacfca23a8b91667aad846e7e41e4e14c7658cc/java/hibernate/src/main/java/com/cockroachlabs/services/OrderService.java#L83
Will fail because the `Order` entity doesn't have an `order_id` column. I think the intention here was to delete the record in `order_products`
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Piste de recherche
Lisez java/hibernate/src/main/java/com/cockroachlabs/services/CustomerService.java autour de la ligne 83 et OrderService.java autour de la ligne 83. Vérifiez le comportement de chaque suppression lorsque des entrées order_products existent, puis vérifiez que la suppression de customer et de order n’échoue plus et que l’enregistrement order_products prévu est supprimé.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- java
- Domaine
- backend, database
- Type d'issue
- Bug
- Difficulté
- 2/5
- Temps estimé
- 1-2 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 35/100