cloudinary / cloudinary/cloudinary_java

`options` map modified directly

Aberta
#383 3 comentários 1 reação 1 responsável Atribuída a @adimiz1 Ver no GitHub
Linguagem predominante
Java
Estrelas
175
Forks
113
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

## Describe the bug in a sentence or two.
When passing in an immutable map to `Uploader.uploadLarge` it errors out because the method [tries to update](https://github.com/cloudinary/cloudinary_java/blob/master/cloudinary-core/src/main/java/com/cloudinary/Uploader.java#L147) the same instance that was passed in to it.
AFAICS, in most places a defensive copy is made from the `options` map, but not here. It caused issues for us as we are using the lib from Clojure interop, and by default, all the collections there are immutable.

## Issue Type (Can be multiple)
[ ] Build - Can’t install or import the SDK
[ ] Performance - Performance issues
[x] Behaviour - Functions aren’t working as expected (Such as generate URL)
[ ] Documentation - Inconsistency between the docs and behaviour
[ ] Other (Specify)

## Steps to reproduce
Use an immutable map as options for `Uploader.uploadLarge` when file is a `java.util.File`.

## Versions and Libraries (fill in the version numbers)
Cloudinary Java SDK version - 1.39.0

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.