cloudinary / cloudinary/cloudinary_java

`options` map modified directly

Abierto
#383 3 comentarios 1 reacción 1 asignado Asignado a @adimiz1 Ver en GitHub
Lenguaje dominante
Java
Estrellas
175
Forks
113
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

## Describe the bug in a sentence or two.
When passing in an immutable map to `Uploader.uploadLarge` it errors out because the method [tries to update](https://github.com/cloudinary/cloudinary_java/blob/master/cloudinary-core/src/main/java/com/cloudinary/Uploader.java#L147) the same instance that was passed in to it.
AFAICS, in most places a defensive copy is made from the `options` map, but not here. It caused issues for us as we are using the lib from Clojure interop, and by default, all the collections there are immutable.

## Issue Type (Can be multiple)
[ ] Build - Can’t install or import the SDK
[ ] Performance - Performance issues
[x] Behaviour - Functions aren’t working as expected (Such as generate URL)
[ ] Documentation - Inconsistency between the docs and behaviour
[ ] Other (Specify)

## Steps to reproduce
Use an immutable map as options for `Uploader.uploadLarge` when file is a `java.util.File`.

## Versions and Libraries (fill in the version numbers)
Cloudinary Java SDK version - 1.39.0

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.