cloudinary / cloudinary/cloudinary_java

`options` map modified directly

Ouverte
#383 3 commentaires 1 réaction 1 personne assignée Assignée à @adimiz1 Voir sur GitHub
Langage dominant
Java
Étoiles
175
Forks
113
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

## Describe the bug in a sentence or two.
When passing in an immutable map to `Uploader.uploadLarge` it errors out because the method [tries to update](https://github.com/cloudinary/cloudinary_java/blob/master/cloudinary-core/src/main/java/com/cloudinary/Uploader.java#L147) the same instance that was passed in to it.
AFAICS, in most places a defensive copy is made from the `options` map, but not here. It caused issues for us as we are using the lib from Clojure interop, and by default, all the collections there are immutable.

## Issue Type (Can be multiple)
[ ] Build - Can’t install or import the SDK
[ ] Performance - Performance issues
[x] Behaviour - Functions aren’t working as expected (Such as generate URL)
[ ] Documentation - Inconsistency between the docs and behaviour
[ ] Other (Specify)

## Steps to reproduce
Use an immutable map as options for `Uploader.uploadLarge` when file is a `java.util.File`.

## Versions and Libraries (fill in the version numbers)
Cloudinary Java SDK version - 1.39.0

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.