cefsharp / cefsharp/cef-binary
nupkg files require all architectures even with selective builds
- 主要言語
- PowerShell
- スター
- 127
- フォーク
- 85
- PR マージ指標
- 30日以内にマージされた PR はありません
説明
While https://github.com/cefsharp/cef-binary/pull/100 initially covered this the final implementation either intentionally or not no longer templates the spec files.
This can cause it to try and restore arm64 binaries when only x64 packages are built. This doesn't require major changes but for arm64 removal for example modifying:
https://github.com/cefsharp/cef-binary/blob/master/NuGet/chromiumembeddedframework.runtime.json?#L13-L17
and potentially:
https://github.com/cefsharp/cef-binary/blob/master/NuGet/chromiumembeddedframework.runtime.nuspec?#L30
it requires some in the main project too (as otherwise the manual copies still try) but probably there straight conditionals would work:
https://github.com/cefsharp/CefSharp/blob/05577b7bf3933a057d42dabe0dc915676f9463a8/NuGet/PackageReference/CefSharp.Common.NETCore.targets?#L204-L224
I can do another PR to either remove these lines when select architectures are specified or go back to a templating system or nothing if it isn't desired for general support of select building.
コントリビューションガイド
このリポジトリのコントリビューションガイドは索引されていません
調査の方向性
Start by comparing the packaging files NuGet/chromiumembeddedframework.runtime.json and NuGet/chromiumembeddedframework.runtime.nuspec with the linked CefSharp.Common.NETCore.targets section. Trace how selective architecture builds affect package restore and manual copies. Done means an x64-only build no longer requires or attempts to restore arm64 binaries.
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- powershell
- 領域
- build-system
- issue の種類
- バグ
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 45/100