cefsharp / cefsharp/cef-binary

nupkg files require all architectures even with selective builds

未关闭
#113 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
PowerShell
星标
127
派生
85
PR 合并指标
30 天内没有已合并 PR

描述

While https://github.com/cefsharp/cef-binary/pull/100 initially covered this the final implementation either intentionally or not no longer templates the spec files.

This can cause it to try and restore arm64 binaries when only x64 packages are built. This doesn't require major changes but for arm64 removal for example modifying:
https://github.com/cefsharp/cef-binary/blob/master/NuGet/chromiumembeddedframework.runtime.json?#L13-L17

and potentially:
https://github.com/cefsharp/cef-binary/blob/master/NuGet/chromiumembeddedframework.runtime.nuspec?#L30

it requires some in the main project too (as otherwise the manual copies still try) but probably there straight conditionals would work:
https://github.com/cefsharp/CefSharp/blob/05577b7bf3933a057d42dabe0dc915676f9463a8/NuGet/PackageReference/CefSharp.Common.NETCore.targets?#L204-L224

I can do another PR to either remove these lines when select architectures are specified or go back to a templating system or nothing if it isn't desired for general support of select building.

贡献指南

这个仓库没有索引到贡献指南

调研方向

首先,将打包文件 NuGet/chromiumembeddedframework.runtime.json 和 NuGet/chromiumembeddedframework.runtime.nuspec 与链接的 CefSharp.Common.NETCore.targets 部分进行比较。跟踪选择性架构构建如何影响包还原和手动复制。完成的标准是,仅 x64 构建不再需要或尝试还原 arm64 二进制文件。

由索引模型根据 Issue 内容生成。

评估

技术栈
powershell
领域
build-system
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
45/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。