callstack / callstack/react-native-pager-view
[BUG] [Accessibility] [iOS] - PagerView with scroll disabled still scrolls when we focus an horizontal scrollview item inside it
- 主要言語
- TypeScript
- スター
- 3.4k
- フォーク
- 476
- 平均マージ
- 10日 21時間
- マージ済み PR(30日)
- 2
説明
First things first: Thanks for your great library!
Here are all the useful info I can share:
## Environment
- As per the example app;
- Old Architecture & New Architecture as well;
## Description
Since accessibility is kind of mandatory for most app, we need to ensure that ours is accessible as well and we are currently fighting with the pager view implementation.
We use the [react-native-tab-view](https://reactnavigation.org/docs/tab-view/) library and initially we though the issue lied there, but in the end we cloned this project, ran the example app and found out that the issue is with the PagerView itself.
This is the error in detail:
If we render an horizontal FlatList, with items styled to fit the width of the screen, inside a PagerView with scrollEnabled set to false, once we start the VoiceOver and try to scroll the FlatList, the PagerView captures the gesture and scroll the tab instead.
> Note: I know that having an horizontal scrollview inside a tab isn't the brightest of all ideas, but you know, you jump the ship, the ship already has this setup, you don't wanna touch it and you end up writing an issue on the react-native-pager-view repository.
## Reproducible Demo
Here you can find the repo: [react-native-pager-view](https://github.com/gladiuscode/react-native-pager-view).
Build the bug/horizontal-scroll-view branch and check out the BasicPagerViewExample screen, you'll see that once you start the VoiceOver, you aren't able to scroll properly.
## Question
Is this library built with accessibility in mind?
コントリビューションガイド
調査の方向性
Build the bug/horizontal-scroll-view branch and open the BasicPagerViewExample screen in the example app. Reproduce the VoiceOver gesture with an horizontal FlatList inside a PagerView whose scrollEnabled is false, then trace the PagerView behavior involved in capturing the gesture. Done means the inner FlatList scrolls correctly without moving the disabled pager.
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- ios, react-native, typescript
- 領域
- accessibility, mobile
- issue の種類
- バグ
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 45/100