callstack / callstack/react-native-pager-view

[BUG] [Accessibility] [iOS] - PagerView with scroll disabled still scrolls when we focus an horizontal scrollview item inside it

Aperta
#971 7 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
3.4k
Fork
476
Merge medio
10g 21h
PR unite (30g)
2

Descrizione

First things first: Thanks for your great library!

Here are all the useful info I can share:

## Environment

- As per the example app;
- Old Architecture & New Architecture as well;

## Description

Since accessibility is kind of mandatory for most app, we need to ensure that ours is accessible as well and we are currently fighting with the pager view implementation.
We use the [react-native-tab-view](https://reactnavigation.org/docs/tab-view/) library and initially we though the issue lied there, but in the end we cloned this project, ran the example app and found out that the issue is with the PagerView itself.

This is the error in detail:

If we render an horizontal FlatList, with items styled to fit the width of the screen, inside a PagerView with scrollEnabled set to false, once we start the VoiceOver and try to scroll the FlatList, the PagerView captures the gesture and scroll the tab instead.

> Note: I know that having an horizontal scrollview inside a tab isn't the brightest of all ideas, but you know, you jump the ship, the ship already has this setup, you don't wanna touch it and you end up writing an issue on the react-native-pager-view repository.

## Reproducible Demo

Here you can find the repo: [react-native-pager-view](https://github.com/gladiuscode/react-native-pager-view).
Build the bug/horizontal-scroll-view branch and check out the BasicPagerViewExample screen, you'll see that once you start the VoiceOver, you aren't able to scroll properly.

## Question

Is this library built with accessibility in mind?

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Build the bug/horizontal-scroll-view branch and open the BasicPagerViewExample screen in the example app. Reproduce the VoiceOver gesture with an horizontal FlatList inside a PagerView whose scrollEnabled is false, then trace the PagerView behavior involved in capturing the gesture. Done means the inner FlatList scrolls correctly without moving the disabled pager.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
ios, react-native, typescript
Ambito
accessibility, mobile
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
45/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.