binn / binn/VRChat.API.Client

Community Feedback Requested: Should we have named clients default to the default client if no default is registered?

未关闭
#4 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
bug enhancement help wanted question
主要语言
C#
星标
6
派生
2
PR 合并指标
30 天内没有已合并 PR

描述

When using DI, if `IVRChatClientFactory.CreateClient()` is called, and no default IVRChat was registered, then it will return the first available named client.

This may lead to unexpected behavior or bugs when consuming the library (and unaware of what the actual problem is), but also may make life easier when clients are left unregistered.

I wanted to obtain community feedback before implementing a complete change.

The implementation of this behavior is located [here](https://github.com/binn/VRChat.API.Client/blob/3ee8416a5108553e0e4e9b05b9a2f1007052962d/VRChat.API.Extensions.Hosting/DefaultVRChatClientFactory.cs#L29) and [here](https://github.com/binn/VRChat.API.Client/blob/3ee8416a5108553e0e4e9b05b9a2f1007052962d/VRChat.API.Extensions.Hosting/VRChatServiceCollectionExtensions.cs#L87)

贡献指南

这个仓库没有索引到贡献指南

调研方向

Start by reading DefaultVRChatClientFactory.cs and VRChatServiceCollectionExtensions.cs at the linked locations to understand how CreateClient() selects a named client when no default is registered. Review the issue's proposed alternatives and gather the requested community feedback; done means the expected behavior is decided and the implementation scope is documented.

由索引模型根据 Issue 内容生成。

评估

技术栈
csharp
领域
backend
Issue 类型
功能
难度
5/5
预计耗时
一周以上
活跃度
停滞
描述清晰度
需要澄清
新手友好度
20/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。