binn / binn/VRChat.API.Client

Community Feedback Requested: Should we have named clients default to the default client if no default is registered?

Ouverte
#4 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
bug enhancement help wanted question
Langage dominant
C#
Étoiles
6
Forks
2
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

When using DI, if `IVRChatClientFactory.CreateClient()` is called, and no default IVRChat was registered, then it will return the first available named client.

This may lead to unexpected behavior or bugs when consuming the library (and unaware of what the actual problem is), but also may make life easier when clients are left unregistered.

I wanted to obtain community feedback before implementing a complete change.

The implementation of this behavior is located [here](https://github.com/binn/VRChat.API.Client/blob/3ee8416a5108553e0e4e9b05b9a2f1007052962d/VRChat.API.Extensions.Hosting/DefaultVRChatClientFactory.cs#L29) and [here](https://github.com/binn/VRChat.API.Client/blob/3ee8416a5108553e0e4e9b05b9a2f1007052962d/VRChat.API.Extensions.Hosting/VRChatServiceCollectionExtensions.cs#L87)

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.