binn / binn/VRChat.API.Client

Community Feedback Requested: Should we have named clients default to the default client if no default is registered?

Abierto
#4 0 comentarios 0 reacciones 0 asignados Ver en GitHub
bug enhancement help wanted question
Lenguaje dominante
C#
Estrellas
6
Forks
2
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

When using DI, if `IVRChatClientFactory.CreateClient()` is called, and no default IVRChat was registered, then it will return the first available named client.

This may lead to unexpected behavior or bugs when consuming the library (and unaware of what the actual problem is), but also may make life easier when clients are left unregistered.

I wanted to obtain community feedback before implementing a complete change.

The implementation of this behavior is located [here](https://github.com/binn/VRChat.API.Client/blob/3ee8416a5108553e0e4e9b05b9a2f1007052962d/VRChat.API.Extensions.Hosting/DefaultVRChatClientFactory.cs#L29) and [here](https://github.com/binn/VRChat.API.Client/blob/3ee8416a5108553e0e4e9b05b9a2f1007052962d/VRChat.API.Extensions.Hosting/VRChatServiceCollectionExtensions.cs#L87)

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.