binn / binn/VRChat.API.Client

Community Feedback Requested: Should we have named clients default to the default client if no default is registered?

Open
#4 0 comments 0 reactions 0 assignees View on GitHub
bug enhancement help wanted question
Dominant language
C#
Stars
6
Forks
2
PR merge metrics
No merged PRs in 30d

Description

When using DI, if `IVRChatClientFactory.CreateClient()` is called, and no default IVRChat was registered, then it will return the first available named client.

This may lead to unexpected behavior or bugs when consuming the library (and unaware of what the actual problem is), but also may make life easier when clients are left unregistered.

I wanted to obtain community feedback before implementing a complete change.

The implementation of this behavior is located [here](https://github.com/binn/VRChat.API.Client/blob/3ee8416a5108553e0e4e9b05b9a2f1007052962d/VRChat.API.Extensions.Hosting/DefaultVRChatClientFactory.cs#L29) and [here](https://github.com/binn/VRChat.API.Client/blob/3ee8416a5108553e0e4e9b05b9a2f1007052962d/VRChat.API.Extensions.Hosting/VRChatServiceCollectionExtensions.cs#L87)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.