benchmark-action / benchmark-action/github-action-benchmark
Action requires GITHUB_TOKEN even for public repositories
- Lingua principale
- TypeScript
- Stelle
- 1.3k
- Fork
- 184
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
If the action is configured not to push and the configured repository is public, then the `GITHUB_TOKEN` should not be required, since the action should be able to clone the repository without it.
Currently the action fails due to the following validation, not because the action can't actually clone the repo.
```js
if (ghRepository) {
validateGitHubToken('gh-repository', githubToken, 'to clone the repository');
}
```
This is undesirable because it unnecessarily leads users to create PATs or fine-grained tokens, increasing their security exposure.
Guida per i contributori
Apri la guida per i contributori
Direzione di ricerca
Start at the shown `ghRepository` validation and trace how repository cloning and push configuration are handled. The change is done when a public repository configured not to push can be cloned without `GITHUB_TOKEN`, while configurations that still require authentication continue to validate it.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- github-actions, typescript
- Ambito
- ci-cd, devops
- Tipo di issue
- Bug
- Difficoltà
- 2/5
- Tempo stimato
- 1-3 ore
- Stato di attività
- Ferma
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 52/100