benchmark-action / benchmark-action/github-action-benchmark

Action requires GITHUB_TOKEN even for public repositories

Abierto
#331 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
TypeScript
Estrellas
1.3k
Forks
184
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

If the action is configured not to push and the configured repository is public, then the `GITHUB_TOKEN` should not be required, since the action should be able to clone the repository without it.

Currently the action fails due to the following validation, not because the action can't actually clone the repo.

```js
if (ghRepository) {
validateGitHubToken('gh-repository', githubToken, 'to clone the repository');
}
```

This is undesirable because it unnecessarily leads users to create PATs or fine-grained tokens, increasing their security exposure.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start at the shown `ghRepository` validation and trace how repository cloning and push configuration are handled. The change is done when a public repository configured not to push can be cloned without `GITHUB_TOKEN`, while configurations that still require authentication continue to validate it.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
github-actions, typescript
Área
ci-cd, devops
Tipo de issue
Error
Dificultad
2/5
Tiempo estimado
1-3 horas
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
52/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.