benchmark-action / benchmark-action/github-action-benchmark

Action requires GITHUB_TOKEN even for public repositories

Ouverte
#331 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
TypeScript
Étoiles
1.3k
Forks
183
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

If the action is configured not to push and the configured repository is public, then the `GITHUB_TOKEN` should not be required, since the action should be able to clone the repository without it.

Currently the action fails due to the following validation, not because the action can't actually clone the repo.

```js
if (ghRepository) {
validateGitHubToken('gh-repository', githubToken, 'to clone the repository');
}
```

This is undesirable because it unnecessarily leads users to create PATs or fine-grained tokens, increasing their security exposure.

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Start at the shown `ghRepository` validation and trace how repository cloning and push configuration are handled. The change is done when a public repository configured not to push can be cloned without `GITHUB_TOKEN`, while configurations that still require authentication continue to validate it.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
github-actions, typescript
Domaine
ci-cd, devops
Type d'issue
Bug
Difficulté
2/5
Temps estimé
1-3 heures
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
52/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.