bbcmicrobit / bbcmicrobit/PythonEditor

A11y: Modal close "button" should be keyboard focusable

未关闭
#355 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
a11y
主要语言
JavaScript
星标
201
派生
126
PR 合并指标
30 天内没有已合并 PR

描述

We can't focus the "x" close button via keyboard:

Screenshot 2020-11-17 at 15 05 07

We can still close the modal via escape key: https://github.com/bbcmicrobit/PythonEditor/pull/310

We could fix this via workaround, or if the modal library get's a fix upstream: https://github.com/HubSpot/vex/pull/134

More info in https://github.com/bbcmicrobit/PythonEditor/issues/347#issuecomment-728986198

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。