bbcmicrobit / bbcmicrobit/PythonEditor
A11y: Modal close "button" should be keyboard focusable
Ouverte
a11y
- Langage dominant
- JavaScript
- Étoiles
- 201
- Forks
- 126
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
We can't focus the "x" close button via keyboard:
We can still close the modal via escape key: https://github.com/bbcmicrobit/PythonEditor/pull/310
We could fix this via workaround, or if the modal library get's a fix upstream: https://github.com/HubSpot/vex/pull/134
More info in https://github.com/bbcmicrobit/PythonEditor/issues/347#issuecomment-728986198
Guide de contribution
Ouvrir le guide de contribution
Évaluation
Cette issue n'a pas encore été évaluée.