bazel-contrib / bazel-contrib/rules_python

Allow glob expression in experimental_requirement_cycles

オープン
#2,255 コメント 8 件 リアクション 0 件 担当者 0 名 GitHub で見る
help wanted
主要言語
Starlark
スター
688
フォーク
721
平均マージ
15時間 7分
マージ済み PR(30日)
76

説明

Currently `pip_parse` supports a feature to "fix" cycles among third-party packages, for example:

```
pip_parse(
...
experimental_requirement_cycles = {
"airflow": [
"apache-airflow",
"apache-airflow-providers-common-sql",
"apache-airflow-providers-sqlite",
"apache-airflow-providers-ftp",
"apache-airflow-providers-http",
"apache-airflow-providers-imap",
],
},
)
```

However it's difficult to keep this list updated, as it needs to include both direct and transitive dependencies. For example ` apache-airflow-providers-common-io` appeared in the locked requirements for one of my clients, and that broke install with a surprising error message.

It would be better to write `"airflow": ["apache-airflow-providers-*"]` so that this is robust to whatever providers are installed. https://github.com/aspect-build/rules_js/blob/main/docs/npm_translate_lock.md#list_patches is an example of a similar repo rule in JS-land which supports globs. Note that bazel-lib provides the starlark glob implementation used there.

FYI @arrdem

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

Start with the pip_parse implementation and its experimental_requirement_cycles handling. Compare the requested behavior with the list_patches glob support in rules_js and the bazel-lib Starlark glob implementation. Done means provider patterns such as apache-airflow-providers-* match the relevant direct and transitive requirements without requiring manual list updates.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
python
領域
build-system
issue の種類
機能追加
難易度
3/5
見積もり時間
1〜2日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
42/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。