bazel-contrib / bazel-contrib/rules_python

Allow glob expression in experimental_requirement_cycles

Aperta
#2,255 8 commenti 0 reazioni 0 assegnatari Vedi su GitHub
help wanted
Lingua principale
Starlark
Stelle
688
Fork
721
Merge medio
15h 7m
PR unite (30g)
76

Descrizione

Currently `pip_parse` supports a feature to "fix" cycles among third-party packages, for example:

```
pip_parse(
...
experimental_requirement_cycles = {
"airflow": [
"apache-airflow",
"apache-airflow-providers-common-sql",
"apache-airflow-providers-sqlite",
"apache-airflow-providers-ftp",
"apache-airflow-providers-http",
"apache-airflow-providers-imap",
],
},
)
```

However it's difficult to keep this list updated, as it needs to include both direct and transitive dependencies. For example ` apache-airflow-providers-common-io` appeared in the locked requirements for one of my clients, and that broke install with a surprising error message.

It would be better to write `"airflow": ["apache-airflow-providers-*"]` so that this is robust to whatever providers are installed. https://github.com/aspect-build/rules_js/blob/main/docs/npm_translate_lock.md#list_patches is an example of a similar repo rule in JS-land which supports globs. Note that bazel-lib provides the starlark glob implementation used there.

FYI @arrdem

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.