bazel-contrib / bazel-contrib/rules_python

gazelle_python.yaml can only use one pip_repository

オープン
#1,971 コメント 3 件 リアクション 3 件 担当者 0 名 GitHub で見る
gazelle help wanted type: feature request
主要言語
Starlark
スター
688
フォーク
721
平均マージ
15時間 7分
マージ済み PR(30日)
76

説明

The `modules_mapping` rule accepts a list of wheels, but then the [manifest generator](https://github.com/bazelbuild/rules_python/blob/7a437cc94ff722d8c088ab6140b0cd940d28c4d7/gazelle/manifest/manifest.go#L150) assumes that all those modules come from a single `pip.parse` call.

Since many Python projects separate dependencies, i.e. https://pip-tools.readthedocs.io/en/stable/#workflow-for-layered-requirements
it's often the case that some users have different requirements repositories, even for the same folder.

For example, in https://github.com/alexeagle/bazel_python_repro/blob/18f4504adcdef9187f68397ea20a4f6672badcc2/app/BUILD.bazel gazelle has generated line 28 as `@pip//python_dotenv`. However that wheel came from [test.in](https://github.com/alexeagle/bazel_python_repro/blob/18f4504adcdef9187f68397ea20a4f6672badcc2/requirements/test.in#L4) installed at [pip.test](https://github.com/alexeagle/bazel_python_repro/blob/18f4504adcdef9187f68397ea20a4f6672badcc2/MODULE.bazel#L28) - so it should have generated `@pip.test//python_dotenv`.
Of course since the wheels were combined in the [modules_mapping]( https://github.com/alexeagle/bazel_python_repro/blob/18f4504adcdef9187f68397ea20a4f6672badcc2/BUILD.bazel#L31) this information is lost and the `gazelle_python.yaml` can't indicate which repo should be used for a given import (no matter what folder the gazelle_python.yaml were to appear in)

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。