bazel-contrib / bazel-contrib/rules_python

gazelle_python.yaml can only use one pip_repository

未关闭
#1,971 3 条评论 3 个 reaction 已指派 0 人 在 GitHub 查看
gazelle help wanted type: feature request
主要语言
Starlark
星标
688
派生
721
平均合并
15 小时 7 分钟
30 天内合并 PR
76

描述

The `modules_mapping` rule accepts a list of wheels, but then the [manifest generator](https://github.com/bazelbuild/rules_python/blob/7a437cc94ff722d8c088ab6140b0cd940d28c4d7/gazelle/manifest/manifest.go#L150) assumes that all those modules come from a single `pip.parse` call.

Since many Python projects separate dependencies, i.e. https://pip-tools.readthedocs.io/en/stable/#workflow-for-layered-requirements
it's often the case that some users have different requirements repositories, even for the same folder.

For example, in https://github.com/alexeagle/bazel_python_repro/blob/18f4504adcdef9187f68397ea20a4f6672badcc2/app/BUILD.bazel gazelle has generated line 28 as `@pip//python_dotenv`. However that wheel came from [test.in](https://github.com/alexeagle/bazel_python_repro/blob/18f4504adcdef9187f68397ea20a4f6672badcc2/requirements/test.in#L4) installed at [pip.test](https://github.com/alexeagle/bazel_python_repro/blob/18f4504adcdef9187f68397ea20a4f6672badcc2/MODULE.bazel#L28) - so it should have generated `@pip.test//python_dotenv`.
Of course since the wheels were combined in the [modules_mapping]( https://github.com/alexeagle/bazel_python_repro/blob/18f4504adcdef9187f68397ea20a4f6672badcc2/BUILD.bazel#L31) this information is lost and the `gazelle_python.yaml` can't indicate which repo should be used for a given import (no matter what folder the gazelle_python.yaml were to appear in)

贡献指南

打开贡献指南

调研方向

Start with the modules_mapping rule and the manifest generator at gazelle/manifest/manifest.go, focusing on how wheel sources are associated with generated labels. Use the layered requirements example to trace the lost repository information; done means imports from different pip repositories generate labels such as @pip.test//python_dotenv rather than always using @pip//.

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
build-system
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
38/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。